Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Wrapper (instead of specializing kernel evaluation on DiffPt) #10

Merged
merged 6 commits into from
Jun 5, 2023

Conversation

FelixBenning
Copy link
Owner

@FelixBenning FelixBenning commented Jun 5, 2023

To avoid the kernelmatrix shenanigans use a wrapper 🏳️

@FelixBenning FelixBenning marked this pull request as ready for review June 5, 2023 14:06
@FelixBenning FelixBenning changed the title Diff wrap Introduce Wrapper (instead of specializing kernel evaluation on DiffPt) Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #10 (c9fc114) into main (4fb8d88) will increase coverage by 1.19%.
The diff coverage is 100.00%.

❗ Current head c9fc114 differs from pull request most recent head c22c92e. Consider uploading reports for the commit c22c92e to get more accurate results

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   56.33%   57.53%   +1.19%     
==========================================
  Files           4        4              
  Lines          71       73       +2     
==========================================
+ Hits           40       42       +2     
  Misses         31       31              
Impacted Files Coverage Δ
src/DifferentiableKernelFunctions.jl 100.00% <ø> (ø)
src/diffKernel.jl 100.00% <100.00%> (ø)
src/partial.jl 61.81% <100.00%> (ø)

@FelixBenning FelixBenning merged commit 917c4da into main Jun 5, 2023
@FelixBenning FelixBenning deleted the DiffWrap branch June 5, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant