Implement filename extension in link completion #114
Conversation
README.md
Outdated
|
|
||
| # Whether wikilinks should include an extension or not (needed for Markor compatibility) | ||
| # for example [[File]] or [[File.md]] | ||
| include_md_extension_wikilink = true |
There was a problem hiding this comment.
I believe we'd want to indicate this is false by default
README.md
Outdated
|
|
||
| # Whether markdown links should include an extension or not | ||
| # for example [File](file.md) or [File](file) | ||
| include_md_extension_md_link = true |
There was a problem hiding this comment.
agreed, yeah. I'll do that now, one sec.
There was a problem hiding this comment.
I just changed that, I squashed the commit so it's the same message:
+ c2941e6...798653f include-extension -> include-extension (forced update)
|
Also, do you have any feedback about the completion code? I am doing a refactor to simplify it right now. |
Hardcode markdown extension Create config entry and make markdown extionsion conditional update README with new config options update README so config reads as false by default
|
🔥 |
Nothing glaring, but I'll have a look through and let you know thoughts that come to me. I'm a data scientist by trade so your Rust is probably a lot better than mine, I'm keen on getting better with it though. Where are you guys chatting, Element / Discord? Keep me in the loop, I love this project and would love to jump in where I can. |
|
Thank you for the kind words! Sounds good. For now the discussion is on here. A few people use the discussions page to post feedback and ideas. Feel free to open issues too. I don't think I'd start a discord yet, but it could be useful for the future. What do you think! |
|
Sounds great, I'll keep an eye on this project and stay around. You've done an excellent job here, good work. |
|
Ahh thank you! I look forward to working with you in the future |
These changes add two options to the config file:
include_md_extension_md_linkinclude_md_extension_wikilinkThese default to
falsein order to preserve past behavior. When set totruecompletions will include the file extension, this is needed for compatibility with other software:[[wikilink.md]][some-link](some-link.md)This seeks to close #113.
Please let me know if there are any specific changes you would like made.