Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint test/index.js #1

Merged
merged 4 commits into from
Feb 2, 2018
Merged

lint test/index.js #1

merged 4 commits into from
Feb 2, 2018

Conversation

UziTech
Copy link

@UziTech UziTech commented Feb 2, 2018

  • added the peer dependencies
  • linted and reformated the test runner
  • added npm run build to create marked.min.js
  • built the minified file

@Feder1co5oave
Copy link
Owner

Feder1co5oave commented Feb 2, 2018 •
edited
Loading

Damn this is awesome, you read my mind about some things that needed to be done. Let me check it up and merge!

@Feder1co5oave
Copy link
Owner

Let me just ask: why did you specify the version for showdown? I think we should maybe specify the major version on all external parsers to make sure their API don't change?
I'm actually writing an issue to check up on dependencies.

@UziTech
Copy link
Author

UziTech commented Feb 2, 2018

sorry that wasn't supposed to be committed

@Feder1co5oave Feder1co5oave merged commit d73174d into Feder1co5oave:lint Feb 2, 2018
@Feder1co5oave Feder1co5oave mentioned this pull request Feb 2, 2018
Closed
7 tasks
@UziTech UziTech deleted the pr/1020 branch April 5, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UziTech @Feder1co5oave