Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard osgi.serviceloader OSGi metadata for provided services #151

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

chrisr3
Copy link
Contributor

@chrisr3 chrisr3 commented Jun 22, 2022

Add OSGi metadata so that an OSGi framework can consume this bundle's SPI services.

The standard service loader mediator is Apache Aries SPI-Fly.

@cowtowncoder
Copy link
Member

Excellent, thank you!

Before merging, I just need one thing: CLA, from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

that is, unless you have already sent one -- apologies if so (and if so LMK and I'll dig it up).
If you do need to send one, the usual way is to print it, fill & sign, scan/photo, email to info at fasterxml dot com.

Since you have contributions for both Woodstox and Jackson, it'd make sense to list those separately on two lines for Project. This only needs to be submitted once and works for all contributions.

Once this is done, I'll be happy to merge this for Woodstox 6.3.0 (and probably go ahead and release it) & similarly for Jackson PR.

@chrisr3
Copy link
Contributor Author

chrisr3 commented Jun 23, 2022

Once this is done, I'll be happy to merge this for Woodstox 6.3.0 (and probably go ahead and release it) & similarly for Jackson PR.

Thanks, I just need to ask our Legal team to review the CLA first.

@cowtowncoder
Copy link
Member

@chrisr3 If it's part of regular job, yes. There is also CCLA if that's easier; but individual one is more common (whether for personal or work-related contributions).

@chrisr3
Copy link
Contributor Author

chrisr3 commented Jun 27, 2022

I have just emailed the signed CLA to [email protected].

@cowtowncoder cowtowncoder merged commit dd06f34 into FasterXML:master Jun 27, 2022
@cowtowncoder cowtowncoder changed the title Add standard osgi.serviceloader OSGi metadata for provided services. Add standard osgi.serviceloader OSGi metadata for provided services Jun 27, 2022
cowtowncoder added a commit that referenced this pull request Jun 27, 2022
@cowtowncoder cowtowncoder added this to the 6.3.0 milestone Jun 27, 2022
@cowtowncoder
Copy link
Member

Included, released as 6.3.0 (hopefully with more useful metadata now :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants