Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail deserialization into LocalDateTime of datetime with timezone #192

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fail deserialization into LocalDateTime of datetime with timezone #192

merged 1 commit into from
Oct 22, 2020

Conversation

angelyan
Copy link
Contributor

Closes #94

@cowtowncoder
Copy link
Member

Thank you @angelyan!

One thing (aside from my verifying if anyone has concerns) that I'd need before merging is CLA from:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and the usual way is to print, fill & sign, scan/photo, email to info at fasterxml dot com.
Once I get that I should be able to merge, backport in for 2.12 (should cherry-pick just fine).
The only question I have is as to whether some handling would be needed for special case (to possibly strip out trailing Z), but it is quite difficult to really know what all users might be doing (kinds of unexpected or misguided usage).
So hopefully by getting this in, releasing 2.12.0-rc2, we could get more validation.

@cowtowncoder
Copy link
Member

Merged, thanks!

Also ended up changing a bit as per comments on #94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialization of timestamps with UTC timezone to LocalDateTime doesn't yield correct time
3 participants