Move jackson-datatype-money module from zalando #48
Conversation
| @@ -0,0 +1,23 @@ | |||
| TODO What goes here? (This original one or another?) | |||
There was a problem hiding this comment.
Need some support with the License information
There was a problem hiding this comment.
If this code happened to be licensed under Apache License 2, we could just use modified version of other modules' LICENSE, like:
This copy of Jackson Jakarta JSONP extension module is licensed under the
Apache (Software) License, version 2.0 ("the License").
See the License for details about distribution rights, and the
specific rights regarding derivative works.
You may obtain a copy of the License at:
http://www.apache.org/licenses/LICENSE-2.0```
But as long as we know what the license used is (we can't change it), should modify above to refer to whatever license there is.
There was a problem hiding this comment.
That is: we have to use the original license -- unless we have original author(s) permission to use some other license.
There was a problem hiding this comment.
Ok so its MIT License instead. So... I guess we could just include full license like so, given it's copyright by Zalando. No changes needed.
But we do need to make sure <license> tag in pom.xml has MIT license (we might have parent pom defaulting to Apache 2)
| @@ -0,0 +1,13 @@ | |||
| //TODO how is this generated | |||
There was a problem hiding this comment.
I am not sure how this file is generated.
Is there some documentation for this?
There was a problem hiding this comment.
I think it would be running
../mvnw moditect:generate-module-info
from new modules project dir. Let me try this on PR.
This provides the base, but must be modified; looking at other modules's module-info.java for inspiration.
There was a problem hiding this comment.
Hmmh. Alas, that command throws NPE.
sri-adarsh-kumar
force-pushed
the
2.19
branch
from
1166e8e
to
f29f0e3
Compare
on-behalf-of: Zalando OSS Community Co-authored-by: Willi Schönborn <[email protected]> Co-authored-by: Philipp Hirch <[email protected]> Co-authored-by: Jörn Horstmann <[email protected]> Co-authored-by: Lauri at Zalando <[email protected]> Co-authored-by: msparer <[email protected]> Co-authored-by: Alexander Yastrebov <[email protected]> Co-authored-by: Alexey Venderov <[email protected]> Co-authored-by: Alexander Yastrebov <[email protected]> Co-authored-by: Arnaud BOIVIN <[email protected]> Co-authored-by: Bartosz Ocytko <[email protected]> Co-authored-by: Carlos Freund <[email protected]> Co-authored-by: Dario Seidl <[email protected]> Co-authored-by: Georgios Andrianakis <[email protected]> Co-authored-by: Lauri at Zalando <[email protected]> Co-authored-by: Martin Prebio <[email protected]> Co-authored-by: Sean Sullivan <[email protected]> Co-authored-by: Touko Vainio-Kaila <[email protected]> Co-authored-by: lukasniemeier-zalando <[email protected]>
sri-adarsh-kumar
force-pushed
the
2.19
branch
from
f29f0e3
to
abaf36d
Compare
|
@cowtowncoder Please review when you have time. |
| </description> | ||
| <url>https://github.com/FasterXML/jackson-datatypes-misc</url> | ||
| <licenses> | ||
| <license> |
There was a problem hiding this comment.
Assuming MIT License as per notes further down, this needs to be changed.
| <name>Jackson datatype: javax-money</name> | ||
| <packaging>jar</packaging> | ||
| <version>2.19.0-SNAPSHOT</version> | ||
| <description>Support for datatypes of Javax Money library (https://javamoney.github.io/) |
There was a problem hiding this comment.
Maybe also mention Money API spec is from JSR 354 (can link to https://javamoney.github.io/api.html I suppose)
Moves jackson-datatype-money module from zalando
Context
Related to #5 and zalando/jackson-datatype-money#224
From the above conversations, there is a consensus to move the zalando/jackson-datatype-money library as a sub-module of this repository.
In order to achieve this, I have moved the files almost 1:1 from the source repository.
Only major changes were related to tests. The source repo had Junit Jupiter tests with
@ParameterizedTest. The destination library already had other tests usingjunitParams.Parameters, so this was adopted.Review Suggestions
Please focus on