-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mismatch in setNextIsUnwrapped(boolean)
in XmlBeanSerializerBase#serializeFieldsFiltered()
#616
Fix mismatch in setNextIsUnwrapped(boolean)
in XmlBeanSerializerBase#serializeFieldsFiltered()
#616
Conversation
Could you provide a test case? |
I have no test cases. |
This looks correct, but I agree with @pjfanning that it'd be really useful to have a test case to show the fix. We can also backport the fix into 2.16 for 2.16.1, I think. I can cherry-pick merge unless you want to re-base (not sure if Github UI has a good way to do that). |
@vmi One other process thing: since this is your first (but hopefully not last! :) ) contribution, I think we will need CLA from: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and it's usually easiest to fill, sign, print & scan/photo, email to Thank you again for contributing this -- looking forward to merging it! |
I added unit test, and sent signed CLA. |
Excellent! CLA successfully received, test looks good; will merge after CI passes. |
setNextIsUnwrapped(boolean)
in XmlBeanSerializerBase#serializeFieldsFiltered()
…se#serializeFieldsFiltered() (#616)
Since this seems like a safe fix, I backported it in 2.16.1 as well so will get released sooner (we only just started 2.17 branch). |
In serializeFields() of XmlBeanSerializerBase, setNextIsUnwrapped(true) is executed in L.200-203, and setNextIsUnwrapped(false) is executed in L.215-219.
However, in serializeFieldsFiltered(), setNextIsUnwrapped(true) is executed in L.282-285, but there is no corresponding setNextIsUnwrapped(false).