Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DeserializationFeature.READ_ENUMS_USING_TO_STRING by default (3.0) #4566

Conversation

JooHyukKim
Copy link
Member

@JooHyukKim JooHyukKim commented Jun 6, 2024

@JooHyukKim JooHyukKim closed this Jun 6, 2024
@JooHyukKim JooHyukKim reopened this Jun 6, 2024
@JooHyukKim
Copy link
Member Author

Re-running CI because of Fuzzer failure (was nearly impossible to read log, due to its enormous volume)

@JooHyukKim
Copy link
Member Author

Fuzzer is failing at build stage with import error.
Anyone seen this before? 🤔

image

@cowtowncoder
Copy link
Member

cowtowncoder commented Jun 6, 2024

I do not recall seeing that error, but I also haven't been paying attention to Fuzzer action.

I think I should just go ahead and disable it, seems to have little value and I think OSS-Fuzz runs their generation elsewhere anyway.

Oddly enough, it runs only for... PRs? And one for jackson-core seems to succeed.
There's one different, wrt permissions, I can try to change that.

@cowtowncoder cowtowncoder added the 3.x Issues to be only tackled for Jackson 3.x, not 2.x label Jun 6, 2024
@cowtowncoder
Copy link
Member

@pjfanning pointed the obvious: Jackson package name means OSS-Fuzz code, built against 2.x, won't work. So this should now be merged, fixed.

@cowtowncoder
Copy link
Member

Will review this and #4567 later today, get merged. Good stuff!

@cowtowncoder cowtowncoder changed the title [ Jackson 3 ] Enable DeserializationFeature.READ_ENUMS_USING_TO_STRING by default Enable DeserializationFeature.READ_ENUMS_USING_TO_STRING by default (3.0) Jun 7, 2024
@cowtowncoder cowtowncoder merged commit 1dface0 into FasterXML:master Jun 7, 2024
6 checks passed
@JooHyukKim
Copy link
Member Author

Will update JSTEP-2 Wiki accordingly.
For this PR and one for SerializationFeature

cc. @cowtowncoder

@cowtowncoder
Copy link
Member

I did some updates but may have missed something so appreciate your help @JooHyukKim.

@JooHyukKim
Copy link
Member Author

I did some updates but may have missed something so appreciate your help @JooHyukKim.

I checked and everything is there 👍🏼

@JooHyukKim JooHyukKim deleted the Change-DeserializationFeature.READ_ENUMS_USING_TO_STRING-default-for-Jackson-3 branch June 9, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issues to be only tackled for Jackson 3.x, not 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants