Implementation of custom object id resolution. #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good -- I'll have to digest this a bit; I think it is great to allow pluggability, but we may need to discuss some of details, once I understand patch more. I have no doubts it works, just want to minimize needs for tweaks afterwards. |
|
Sure, take your time, no rush. |
|
As per comments on annotations PR, I think this is fine. If need be, we can tweak it after the fact; and functionality itself is very valuable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #176, with a larger scope than what was suggested. It handles all resolution of ID with a new interface,
ObjectIdResolver, which is basically the deserialization twin ofObjectIdGenerator.