Reduce contention in TypeNameIdResolver. Fixes [#2556] #2557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our production system has shown threads contending on a lock in TypeNameIdResolver:
This was reported in #2566. Investigation and benchmarks have shown that the contention is actually on the
get
/ read of the_typeToId
map, because it issynchronized
.Moving the
write
part out has no measurable effect since the map is populated.Swapping for a
ConcurrentHashMap
gives around10%
additional throughput on heavy json serialisation (using the same object mapper. using different object mappers uses different caches).For symmetry,
_idToType
has also been changed. Technically the previous version was not threadsafe, as even concurrent HashMap reads can deadlock.