Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of global static TypeFactory singleton from 3.0 #4659

Closed
cowtowncoder opened this issue Aug 11, 2024 · 1 comment
Closed

Remove use of global static TypeFactory singleton from 3.0 #4659

cowtowncoder opened this issue Aug 11, 2024 · 1 comment
Labels
3.0 Issue planned for initial 3.0 release
Milestone
3.0.0

Comments

@cowtowncoder
Copy link
Member

Describe your Issue

(note: offshoot of FasterXML/jackson-core#1321)

Unlike all other caches, cache for the default instance of TypeFactory is not bound to one specific ObjectMapper and can therefore lead to unintended Class retention.
This should not happen: each ObjectMapper should have its own TypeFactory instead of global singleton.

Change is probably not possible for 2.x but should be doable for 3.0.
@cowtowncoder cowtowncoder added the 3.0 Issue planned for initial 3.0 release label Aug 11, 2024
@cowtowncoder cowtowncoder mentioned this issue Aug 11, 2024
Closed
cowtowncoder added a commit that referenced this issue Oct 11, 2024
@cowtowncoder
Prep work for #4659 (reduce use of TypeFactory.defaultInstance())
d2afc2f
cowtowncoder added a commit that referenced this issue Oct 11, 2024
@cowtowncoder
Prep work for #4659 (reduce use of TypeFactory.defaultInstance()) (#4745
61ef2cb 
)
cowtowncoder added a commit that referenced this issue Oct 13, 2024
@cowtowncoder
More work towards #4659
1643c1e
cowtowncoder added a commit that referenced this issue Oct 13, 2024
@cowtowncoder
Fix #4659: remove TypeFactory.defaultInstance()
d510083
@cowtowncoder cowtowncoder added this to the 3.0.0 milestone Oct 13, 2024
@cowtowncoder
Copy link
Member Author

Did refactor 2.x code to reduce usage of TypeFactory.defaultInstance() but the actual removal has to go in 3.0.

cowtowncoder added a commit that referenced this issue Oct 13, 2024
@cowtowncoder
Fix #4659: remove TypeFactory.defaultInstance() (#4747)
b522ba3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 Issue planned for initial 3.0 release
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@cowtowncoder