Declare osgi.serviceloader.registrar requirement as optional. #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Rankin <[email protected]>
|
First of all, thank you @chrisr3 for submitting this. Second: I really wish we had gotten this in 2.14.0-rc2 to get some testing. My spider sense is tingling wrt Android users and others soon reporting a problem with "missing" annotation (some tool somewhere freaking out where it really shouldn't). But I think it is probably best to merge this in, still. |
|
Or, maybe there's no problem since we already have an annotation. We'll see :) |
cowtowncoder
added a commit
that referenced
this pull request
Oct 18, 2022
cowtowncoder
added a commit
that referenced
this pull request
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with Woodstox PR#155, do not require that the OSGi framework also contains Apache SPI-Fly.
Note: addition to #768.