Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal OSGi metadata as per #768 #805

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

cowtowncoder
Copy link
Member

@cowtowncoder cowtowncoder commented Aug 1, 2022

So, as per #768 we may want to add minimal OSGi metadata here, and eventually across all format backends plus probably jackson-databind. But starting with basics.

Also note that if this works, 3.0 (master) uses bit different bindings (TokenStreamFactory that JsonFactory implements) -- but for 2.x we'll stick to JsonFactory as being the base class every format backend implements.

@cowtowncoder
Copy link
Member Author

@chrisr3 Is this what you meant in #768? Not sure how to test goodness (or lack thereof).

Copy link
Contributor

@chrisr3 chrisr3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that looks right. AFAIK this is the only jackson-core class with a META-INF/services entry, and jackson-core doesn't explicitly use ServiceLoader.load() either so this should be the only annotation that needs adding.

@cowtowncoder cowtowncoder merged commit a0f45a1 into 2.14 Aug 2, 2022
@cowtowncoder cowtowncoder deleted the tatu/768-osgi-metadata branch August 2, 2022 20:20
@cowtowncoder cowtowncoder restored the tatu/768-osgi-metadata branch August 2, 2022 20:20
@cowtowncoder cowtowncoder deleted the tatu/768-osgi-metadata branch August 2, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants