Support for parsing versions from maven pom.properties files #1
+44
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. I created [http://jira.codehaus.org/browse/JACKSON-745] for this, and can merge the request. |
cowtowncoder
added a commit
that referenced
this pull request
Jan 3, 2012
Support for parsing versions from maven pom.properties files [JACKSON-745]
CatherineRSJ
referenced
this pull request
in CatherineRSJ/jackson-core-tests
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this in my own project, and then thought it would be more useful in jackson-core. Maven puts version info by default in META-INF/maven/groupId/artifactId/pom.properties, so it makes sense that jackson-core should provide a convenience method for loading Version objects from it that jackson modules can use. The method also accepts a classloader, which should ensure it works in OSGi environments.