Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for passing char[] as input, allow reuse of given buffer #138

Closed
cowtowncoder opened this issue Apr 18, 2014 · 0 comments
Closed
Milestone

Comments

@cowtowncoder
Copy link
Member

Currently it is possible to hand a byte[], which avoids needing to allocate underlying read buffer, as well as one or more read(s). But there is no similar counterpart for char[]. So let's add it.

Doing so could also allow some minor optimization for the case of passing in a String; if profiling shows it is faster to just explicitly get underlying characters, we could do that on JsonFactory side, instead of building a StringReader.

@cowtowncoder cowtowncoder added this to the 2.4.0 milestone Apr 18, 2014
cowtowncoder added a commit that referenced this issue Apr 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant