-
-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default recycler pool to newConcurrentDequePool()
in 2.18
#1266
Comments
concurrentDequePool
in 2.18bewConcurrentDequePool()
in 2.18
Actually. Given all the feedback received so far, it appears that the ThreadLocal-based pool still performs best for pre-Loom threading. So let's postpone this change to 3.0 ( |
bewConcurrentDequePool()
in 2.18newConcurrentDequePool()
in 2.18
@cowtowncoder I would really appreciate it if you could clarify some doubts for me: 1- What about an application using virtual threads? Did you notice any problems with newConcurrentDequePool() when used in conjunction with virtual threads? 2 - In the 3.0 release, you think the default will be newConcurrentDequePool() or you are considering another alternative? 3 - For Jackson 2.17.x, is newConcurrentDequePool() the recomended approach with virtual threads? |
I have no experience on virtual threads myself, unfortunately: I hope others (like @mariofusco ) can comment here. With that:
|
(note: follow-up to #1256)
Altho we will revert back to
ThreadLocalPool
for 2.17.1 and rest of 2.17.x, we do want to move away in 2.18.Let's use "ConcurrentDequePool" (via
JsonRecyclerPools.newConcurrentDequePool()
) as that seems to behave better and have otherwise similar approach as shared-lock-pool, but without potentially failing acquire that can lead to imbalanced handling & ever-growing pool.The text was updated successfully, but these errors were encountered: