Allow custom goal colours #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this work in the rendering? |
Yeah all good! Here's a selection of the colours rendered for the empty environment:
|
pseudo-rnd-thoughts
approved these changes
Oct 6, 2024
pseudo-rnd-thoughts
merged commit a6cfc0e
into
Farama-Foundation:master
2 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
I've often found it useful to be able to customise the goal colour when building custom environments for example, when making an environment that can have multiple goals etc.
I'm pretty confident this doesn't break or change anything (as I have just made the default "green" as it always is), but do let me know if any concerns -- thanks!
Type of change
Please delete options that are not relevant.