Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nil cachescale issue after loading toml config file #344

Closed
wants to merge 1 commit into from

Conversation

hadv
Copy link
Contributor

@hadv hadv commented Jul 26, 2022

Set cachescale to default cacheRatio after loading config file to avoid nil pointer exception when running node with toml config file

It seems the side effect of #337

@hadv hadv requested a review from andrecronje as a code owner July 26, 2022 04:23
@hadv hadv requested review from uprendis, a user and rus-alex and removed request for a user July 26, 2022 04:24
@uprendis
Copy link
Contributor

It seems this issue is fixed in #343 by erasing cachescale from this struct

@hadv
Copy link
Contributor Author

hadv commented Jul 26, 2022

It seems this issue is fixed in #343 by erasing cachescale from this struct

okay, I need to run test the code that base on current develop branch and facing the issue. If we merge the #343 then we don't need this PR anymore. I just use as local for testing only.

@hadv hadv closed this Jul 26, 2022
@hadv hadv deleted the fix-nil-cachescale branch July 26, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants