Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC gas capping #391

Merged
merged 2 commits into from
Jan 23, 2025
Merged

RPC gas capping #391

merged 2 commits into from
Jan 23, 2025

Conversation

jenikd
Copy link
Collaborator

@jenikd jenikd commented Jan 22, 2025

This PR fixes gas cap of the RPC requests. Because of Tosca maximum gas has to be limited to MaxInt64. If it was higher, the EVM immediately failed because of out of gas.

Copy link
Collaborator

@HerbertJordan HerbertJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@jenikd jenikd merged commit fbfc277 into develop Jan 23, 2025
2 checks passed
@jenikd jenikd deleted the jenikd/fix__rpc_gas_capping branch January 23, 2025 07:25
wsodsong pushed a commit that referenced this pull request Jan 23, 2025
* Fix rpc gas capping

* Add test for gas capping when creating tx message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants