Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storybook webpack error (#267) Scripting #268

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

tkmcmaster
Copy link
Collaborator

@tkmcmaster tkmcmaster commented Nov 25, 2024

#267 into scripting branch
⚠️ DO NOT CLICK REBASE BRANCH ⚠️

  • Fixed issue with storybook and webpack findDOMNode error
    • With Next 15, we were getting some storybook errors about deprecated findDOMNode. The fix is to specify a nodeRef on TransitionGroups so findDOMNode is not called
  • Added webpack typings to next.js and storybook
  • Updated version for release

* Fixed issue with storybook and webpack findDOMNode error

- With Next 15, we were getting some storybook errors about deprecated findDOMNode. The fix is to specify a nodeRef on TransitionGroups so findDOMNode is not called

* Added webpack typings to next.js and storybook

* Updated version for release
@tkmcmaster tkmcmaster requested a review from a team November 25, 2024 21:02
@tkmcmaster tkmcmaster self-assigned this Nov 25, 2024
@tkmcmaster tkmcmaster marked this pull request as ready for review November 25, 2024 21:14
Copy link
Collaborator

@summersjc summersjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for specifying to not rebase

@tkmcmaster tkmcmaster merged commit 787f4e3 into 0.6.0-scripting-dev Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants