Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML file enumeration value superstructures #106

Open
dthaler opened this issue Oct 13, 2023 · 2 comments
Open

YAML file enumeration value superstructures #106

dthaler opened this issue Oct 13, 2023 · 2 comments

Comments

@dthaler
Copy link
Collaborator

dthaler commented Oct 13, 2023

In the YAML file format, superstructures is not allowed for enumeration values.

This limitation resulted in bugs like #100 since it could not be validated. If instead, https://gedcom.io/terms/v7/enum-BIC had had something like

superstructures:
  "https://gedcom.io/terms/v7/SLGC": "{0:1}"

then the bug with

1 BAPL
2 STAT BIC

would have been automatically detected.

@dthaler
Copy link
Collaborator Author

dthaler commented Nov 20, 2023

Another possibility would be to allow value of to contain a URI of a structure, not just a URI of an enum set. E.g.:

https://gedcom.io/terms/v7/enum-BIC might have:

value of:
  - "https://gedcom.io/terms/v7/SLGC"

instead of what it has now:

value of:
  - "https://gedcom.io/terms/v7/enumset-ord-STAT"

The former is more specific than the latter, since multiple structures have type https://gedcom.io/terms/v7/enumset-ord-STAT but BIC is only legal under SLGC.

dthaler added a commit that referenced this issue Nov 21, 2023
This is one proposal to address #106

Signed-off-by: Dave Thaler <[email protected]>
@dthaler
Copy link
Collaborator Author

dthaler commented Nov 30, 2023

GEDCOM Steering Commitee Discussion 11/30/2023:
We can use 3 different enumsets (for SLGC, SLGS, and for others), can generate a PR to review for next time.

dthaler pushed a commit to dthaler/GEDCOM that referenced this issue Dec 6, 2023
Per GEDCOM Steering Committee discussion on
FamilySearch/GEDCOM.io#106

Note that this does not affect what is permitted in GEDCOM,
it just improves the ability of tools to validate what is permitted.

Signed-off-by: Dave Thaler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant