feat: add linked accounts page #883

michaelhthomas · 2024-07-21T18:27:20Z

Description

Adds a "Linked Accounts" page to the user settings, allowing managing of linked media server (Plex, Jellyfin) accounts, including linking an account to your existing local user, or removing a linked account to become a local user. This page doesn't add much new functionality (except the ability to unlink accounts), but is intended to lay the groundwork for a new and improved implementation of #183 which allows the secure linking of OIDC accounts with existing local accounts.

Screenshot (if UI-related)

Plex Linked Accounts Page	Link Account Dropdown

Jellyfin Linked Accounts Page	Link Jellyfin Modal

Emby Linked Accounts Page	Link Emby Modal

To-Dos

Successful build pnpm build
Translation keys pnpm i18n:extract
Database migration (if required)

Issues Fixed or Closed

Fixes #XXXX

michaelhthomas · 2024-07-21T18:30:57Z

Some outstanding questions / TODOs:

Should it be possible to link Plex accounts with a different email address? Right now I'm leaning towards no for simplicity's sake, since otherwise we would have to change how the auth linking works as well.
~~Need to make sure you can't lock yourself out of your account. Particularly, need to make sure that users with a media server account do not unlink it without first setting a password~~
~~Emby? I haven't tested it at all and it currently doesn't have a logo, so will probably just show the jellyfin one~~
Will need help testing this, particularly with Plex since I don't personally use it

gauthier-th

Just a few comments for now.
And you will add Emby once the PR with Jellyfin/Emby as different server types will be merged right?
Otherwise it's great I like it, good job!

server/entity/User.ts

src/components/Common/Dropdown/index.tsx

michaelhthomas · 2024-07-27T17:59:35Z

And you will add Emby once the PR with Jellyfin/Emby as different server types will be merged right?

Yep, that's the plan currently. Hopefully that PR will make emby a lot easier to integrate.

github-actions · 2024-07-30T16:13:19Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

michaelhthomas · 2024-07-30T16:20:51Z

Unified the two dropdown components and addressed a few other issues with the frontend.

michaelhthomas · 2024-08-01T15:48:24Z

Rebased on feat-server-type-setup and added support for emby

github-actions · 2024-08-19T17:25:41Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

Fallenbagel · 2024-08-20T21:36:23Z

Rebased on feat-server-type-setup and added support for emby

That pr has now been merged

Gauvino · 2024-09-16T20:17:01Z

Why this PR is still in draft any reason for this @michaelhthomas ?

gauthier-th · 2024-09-30T14:34:19Z

Hi @michaelhthomas, could you please rebase this on develop and make it ready for review if everything is ok?

…counts

Adds a shared component for plain dropdown menus, based on the headlessui Menu component. Updates the `ButtonWithDropdown` component to use the same inner components, ensuring that the only difference between the two components is the trigger button, and both use the same components for the actual dropdown menu.

…ounts

Prevents the primary administrator from unlinking their media server account (which would break sync). Additionally, prevents users without a configured local email and password from unlinking their accounts, which would render them unable to log in.

michaelhthomas · 2024-10-18T15:58:26Z

@gauthier-th Rebased on develop. This should be ready for review now, but will probably need some testing. I've personally tested with Jellyfin, Plex, and Emby, but this could definitely use some independent testing.

TheRedCyclops · 2024-11-01T18:18:15Z

Is there a preview tag for testing on docker?

gauthier-th · 2024-11-01T22:02:05Z

Is there a preview tag for testing on docker?

I've just created one: preview-linked-accounts (will be available in ~30min)

gauthier-th

Here are a few more remarks after a detailed review. I still have to test it though.
Feel free to challenge me if you disagree on something.

overseerr-api.yml

server/routes/user/usersettings.ts

src/components/UserProfile/UserSettings/UserLinkedAccountsSettings/index.tsx

src/components/Common/Dropdown/index.tsx

…ecks

michaelhthomas · 2024-11-12T17:26:22Z

@gauthier-th Updated to address feedback, thanks for reviewing!

server/routes/user/usersettings.ts

gauthier-th

LGTM.
A few more tests are welcome though.

github-actions · 2024-11-16T15:57:54Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

gauthier-th · 2024-11-24T19:26:06Z

@michaelhthomas I think this will be merged soon. Could you please rebase on develop and fix the conflicts? 🙏

michaelhthomas force-pushed the feat/linked-accounts branch from 4f53316 to 7cc7756 Compare July 21, 2024 23:02

gauthier-th reviewed Jul 24, 2024

View reviewed changes

server/entity/User.ts Outdated Show resolved Hide resolved

src/components/Common/Dropdown/index.tsx Show resolved Hide resolved

michaelhthomas force-pushed the feat/linked-accounts branch from 7cc7756 to 9da4fbb Compare July 30, 2024 16:13

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Jul 30, 2024

michaelhthomas force-pushed the feat/linked-accounts branch from 9da4fbb to 4866427 Compare July 30, 2024 16:14

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Jul 30, 2024

gauthier-th linked an issue Jul 31, 2024 that may be closed by this pull request

[Feature request] SSO #86

Open

michaelhthomas force-pushed the feat/linked-accounts branch from cffbbc4 to 72b28f4 Compare August 1, 2024 15:47

michaelhthomas changed the base branch from develop to feat-server-type-setup August 1, 2024 15:47

gauthier-th mentioned this pull request Aug 12, 2024

Roadmap for Jellyseerr #926

Open

15 tasks

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Aug 19, 2024

lucaam mentioned this pull request Sep 13, 2024

feat: support OIDC authentication #184

Open

3 tasks

michaelhthomas added 7 commits October 18, 2024 11:40

feat(linked-accounts): create page and display linked media server ac…

4b46b32

…counts

refactor(modal): add support for configuring button props

71ee4d7

feat(linked-accounts): add support for linking/unlinking jellyfin acc…

c664b40

…ounts

feat(linked-accounts): support linking/unlinking plex accounts

97c3935

feat(linked-accounts): support linking/unlinking emby accounts

4a32662

michaelhthomas force-pushed the feat/linked-accounts branch from 72b28f4 to 4a32662 Compare October 18, 2024 15:54

michaelhthomas changed the base branch from feat-server-type-setup to develop October 18, 2024 15:54

michaelhthomas marked this pull request as ready for review October 18, 2024 15:56

michaelhthomas requested a review from Fallenbagel as a code owner October 18, 2024 15:56

github-actions bot removed the merge conflict Cannot merge due to merge conflicts label Oct 19, 2024

gauthier-th reviewed Nov 4, 2024

View reviewed changes

michaelhthomas added 6 commits November 12, 2024 10:13

style(dropdown): improve style class application

3681fb1

fix(server): improve error handling and API spec

d49fd7e

style(usersettings): improve syntax & performance of user password ch…

fe2c4a4

…ecks

style(linkedaccounts): use applicationName in page description

8926859

fix(linkedaccounts): resolve typo

5d3658e

refactor(app): remove RequestError class

470c15c

github-advanced-security bot found potential problems Nov 12, 2024

View reviewed changes

server/routes/user/usersettings.ts Dismissed Show dismissed Hide dismissed

gauthier-th approved these changes Nov 15, 2024

View reviewed changes

github-actions bot added the merge conflict Cannot merge due to merge conflicts label Nov 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add linked accounts page #883

feat: add linked accounts page #883

michaelhthomas commented Jul 21, 2024 •

edited

Loading

michaelhthomas commented Jul 21, 2024 •

edited

Loading

gauthier-th left a comment

michaelhthomas commented Jul 27, 2024

github-actions bot commented Jul 30, 2024

michaelhthomas commented Jul 30, 2024

michaelhthomas commented Aug 1, 2024

github-actions bot commented Aug 19, 2024

Fallenbagel commented Aug 20, 2024

Gauvino commented Sep 16, 2024

gauthier-th commented Sep 30, 2024

michaelhthomas commented Oct 18, 2024

TheRedCyclops commented Nov 1, 2024

gauthier-th commented Nov 1, 2024 •

edited

Loading

gauthier-th left a comment

michaelhthomas commented Nov 12, 2024

gauthier-th left a comment

github-actions bot commented Nov 16, 2024

gauthier-th commented Nov 24, 2024

feat: add linked accounts page #883

Are you sure you want to change the base?

feat: add linked accounts page #883

Conversation

michaelhthomas commented Jul 21, 2024 • edited Loading

Description

Screenshot (if UI-related)

To-Dos

Issues Fixed or Closed

michaelhthomas commented Jul 21, 2024 • edited Loading

gauthier-th left a comment

Choose a reason for hiding this comment

michaelhthomas commented Jul 27, 2024

github-actions bot commented Jul 30, 2024

michaelhthomas commented Jul 30, 2024

michaelhthomas commented Aug 1, 2024

github-actions bot commented Aug 19, 2024

Fallenbagel commented Aug 20, 2024

Gauvino commented Sep 16, 2024

gauthier-th commented Sep 30, 2024

michaelhthomas commented Oct 18, 2024

TheRedCyclops commented Nov 1, 2024

gauthier-th commented Nov 1, 2024 • edited Loading

gauthier-th left a comment

Choose a reason for hiding this comment

michaelhthomas commented Nov 12, 2024

gauthier-th left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 16, 2024

gauthier-th commented Nov 24, 2024

michaelhthomas commented Jul 21, 2024 •

edited

Loading

michaelhthomas commented Jul 21, 2024 •

edited

Loading

gauthier-th commented Nov 1, 2024 •

edited

Loading