Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation on fr.json #446

Merged
merged 21 commits into from
Aug 21, 2023
Merged

Fix translation on fr.json #446

merged 21 commits into from
Aug 21, 2023

Conversation

Gauvino
Copy link
Contributor

@Gauvino Gauvino commented Aug 5, 2023

Description

Rework of all the french translation:

Added missing line and translate it
Translate wrong one
Correct all the orthographic and ponctuation fault
Sort out all the line

@Gauvino Gauvino requested a review from Fallenbagel as a code owner August 5, 2023 18:34
@Gauvino Gauvino changed the title Fix sidebar of fr.json Fix translation on fr.json Aug 5, 2023
@Gauvino
Copy link
Contributor Author

Gauvino commented Aug 7, 2023

@Fallenbagel do you need something else to merge it ?

@Fallenbagel
Copy link
Owner

No I just need some time to review it

@Gauvino
Copy link
Contributor Author

Gauvino commented Aug 7, 2023

No I just need some time to review it

no problem take your time

Copy link

@WizzardHub WizzardHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+

Copy link

@Poloin34 Poloin34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fallenbagel Fallenbagel merged commit 3fd0168 into Fallenbagel:develop Aug 21, 2023
@Fallenbagel
Copy link
Owner

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Fallenbagel
Copy link
Owner

@all-contributors please add @Gauvino for translation

Copy link
Contributor

@Fallenbagel

I've put up a pull request to add @Gauvino! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants