Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jellyfinapi): improve logging of jellyfin api #1089

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Fallenbagel
Copy link
Owner

Description

This PR improves the logging of jellyfin api. This will also fix the wrong logging of throwing an invalid credentials when jellyfin/emby is unreachable.

Screenshot (if UI-related)

To-Dos

  • Successful build pnpm build
  • Translation keys pnpm i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

This commit improves the logging of jellyfin api. This will also fix the wrong logging of throwing
an invalid credentials when jellyfin/emby is unreachable.

re #1053
Copy link
Collaborator

@gauthier-th gauthier-th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauthier-th gauthier-th merged commit 5a13226 into develop Nov 12, 2024
7 checks passed
@gauthier-th gauthier-th deleted the refactor-jellyfinApi-logging branch November 12, 2024 21:26
@Fallenbagel
Copy link
Owner Author

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

thibodelanghe pushed a commit to thibodelanghe/jellyseerr that referenced this pull request Dec 18, 2024
)

This commit improves the logging of jellyfin api. This will also fix the wrong logging of throwing
an invalid credentials when jellyfin/emby is unreachable.

re Fallenbagel#1053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants