Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace missing at creation time #128

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

lucasreed
Copy link
Contributor

This should fix #53 and #106

I also documented behavior for #84 but did not change the behavior for now.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #128 into master will decrease coverage by 1.71%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage    62.1%   60.38%   -1.72%     
==========================================
  Files           4        4              
  Lines         409      414       +5     
==========================================
- Hits          254      250       -4     
- Misses        107      114       +7     
- Partials       48       50       +2
Impacted Files Coverage Δ
pkg/reconciler/reconciler.go 48.01% <33.33%> (-0.72%) ⬇️
pkg/reconciler/parser.go 81.88% <0%> (-3.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216f235...721b3f3. Read the comment docs.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was easier than expected.

@lucasreed
Copy link
Contributor Author

I have an idea for more testing that will cover what was removed here. I'll worry about that in a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rbac-manager doesn't handle the case where a namespace does not exist and is later created
2 participants