Merge branch 'fix/issue#34' into audit-fixes

Fairblock · Jul 11, 2023 · 406cb40 · 406cb40
2 parents ac47c8d + a86d001
commit 406cb40
Show file tree

Hide file tree

Showing 3 changed files with 128 additions and 28 deletions.
diff --git a/proto/fairyring/keyshare/tx.proto b/proto/fairyring/keyshare/tx.proto
@@ -37,6 +37,8 @@ message MsgSendKeyshareResponse {
   uint64 keyshareIndex       = 4;
   uint64 blockHeight         = 5;
   uint64 receivedBlockHeight = 6;
+  bool   success             = 7;
+  string errorMessage        = 8;
 }
 
 

diff --git a/x/keyshare/keeper/msg_server_send_keyshare.go b/x/keyshare/keeper/msg_server_send_keyshare.go
@@ -68,6 +68,8 @@ func (k msgServer) SendKeyshare(goCtx context.Context, msg *types.MsgSendKeyshar
 			KeyshareIndex:       msg.KeyShareIndex,
 			ReceivedBlockHeight: uint64(ctx.BlockHeight()),
 			BlockHeight:         msg.BlockHeight,
+			Success:             false,
+			ErrorMessage:        "Invalid KeyShare",
 		}, nil
 	}
 
@@ -129,6 +131,7 @@ func (k msgServer) SendKeyshare(goCtx context.Context, msg *types.MsgSendKeyshar
 			KeyshareIndex:       msg.KeyShareIndex,
 			ReceivedBlockHeight: uint64(ctx.BlockHeight()),
 			BlockHeight:         msg.BlockHeight,
+			Success:             true,
 		}, nil
 	}
 
@@ -192,6 +195,7 @@ func (k msgServer) SendKeyshare(goCtx context.Context, msg *types.MsgSendKeyshar
 		KeyshareIndex:       msg.KeyShareIndex,
 		ReceivedBlockHeight: uint64(ctx.BlockHeight()),
 		BlockHeight:         msg.BlockHeight,
+		Success:             true,
 	}, nil
 }
 

diff --git a/x/keyshare/types/tx.pb.go b/x/keyshare/types/tx.pb.go