Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix role pallet total members #254

Merged
merged 7 commits into from
Feb 25, 2023
Merged

Fix role pallet total members #254

merged 7 commits into from
Feb 25, 2023

Conversation

cuteolaf
Copy link
Member

TotalMembers counter in pallet-role was not getting incremented correctly.

ndkazu
ndkazu requested changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@ndkazu ndkazu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both PRs could and should be merged into 1 PR including all the corrections (additional checks, and new representative field). Also, the flow problem mentionned is just the result of a wrong testing (see comments): the test file should be corrected.

pallets/asset_management/src/tests.rs Show resolved Hide resolved
@cuteolaf cuteolaf merged commit ea32c5e into main Feb 25, 2023
@cuteolaf cuteolaf deleted the fix-role-pallet-total-members branch February 25, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkazu ndkazu ndkazu requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuteolaf @ndkazu