Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pallet_identity to the runtime #211

Merged
merged 7 commits into from
Nov 18, 2022
Merged

add pallet_identity to the runtime #211

merged 7 commits into from
Nov 18, 2022

Conversation

cuteolaf
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2022

Codecov Report

Merging #211 (28b4666) into main (933a3b9) will decrease coverage by 0.29%.
The diff coverage is 77.85%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   80.81%   80.51%   -0.30%     
==========================================
  Files          58       58              
  Lines        5071     5092      +21     
==========================================
+ Hits         4098     4100       +2     
- Misses        973      992      +19     
Impacted Files Coverage Δ
node/src/chain_spec.rs 0.00% <ø> (ø)
pallets/asset_management/src/mock.rs 75.00% <ø> (ø)
pallets/roles/src/lib.rs 75.00% <0.00%> (-0.66%) ⬇️
pallets/voting/src/lib.rs 79.32% <ø> (ø)
runtime/src/lib.rs 12.22% <ø> (ø)
pallets/roles/src/functions.rs 84.61% <36.84%> (-9.01%) ⬇️
pallets/bidding/src/lib.rs 70.00% <65.95%> (-2.08%) ⬇️
pallets/asset_management/src/lib.rs 22.85% <75.00%> (+4.10%) ⬆️
pallets/asset_management/src/functions.rs 44.44% <100.00%> (ø)
pallets/asset_management/src/tests.rs 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cuteolaf cuteolaf requested a review from ndkazu November 16, 2022 15:25
node/src/chain_spec.rs Outdated Show resolved Hide resolved
Copy link
Member

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes and let's keep small fixes away from PR for what they are intended for.

runtime/src/lib.rs Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
pallets/bidding/src/tests.rs Show resolved Hide resolved
Copy link
Member

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding setting the identities, can you check this

Apparently we can set stuff with frame trait on_genesis think this will be a root call.

node/src/chain_spec.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
@cuteolaf cuteolaf linked an issue Nov 17, 2022 that may be closed by this pull request
4 tasks
node/src/chain_spec.rs Outdated Show resolved Hide resolved
Copy link
Member

@ilhanu ilhanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for correcting some of the reviewed parts. Got that you don't want to implement the on-genesis implementation in this PR. It's still worth looking into it will just save us a lot of work to have a genesis config of that.

@cuteolaf cuteolaf merged commit d2d2060 into main Nov 18, 2022
@cuteolaf cuteolaf deleted the add-pallet-identity branch November 19, 2022 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Identity Pallet and Configuration Genesis
5 participants