-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pallet_identity to the runtime #211
Conversation
Codecov Report
@@ Coverage Diff @@
## main #211 +/- ##
==========================================
- Coverage 80.81% 80.51% -0.30%
==========================================
Files 58 58
Lines 5071 5092 +21
==========================================
+ Hits 4098 4100 +2
- Misses 973 992 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes and let's keep small fixes away from PR for what they are intended for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding setting the identities, can you check this
Apparently we can set stuff with frame trait on_genesis
think this will be a root call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for correcting some of the reviewed parts. Got that you don't want to implement the on-genesis implementation in this PR. It's still worth looking into it will just save us a lot of work to have a genesis config of that.
No description provided.