206 bidding pallet update process onboarded assets #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 78.39% 79.61% +1.21%
==========================================
Files 51 53 +2
Lines 4383 4571 +188
==========================================
+ Hits 3436 3639 +203
+ Misses 947 932 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ndkazu
approved these changes
Nov 16, 2022
cuteolaf
reviewed
Nov 16, 2022
Comment on lines
+275
to
+283
| let collections = all::<Nft::PossibleCollections>().collect::<Vec<_>>(); | ||
| let mut possible_collection = Nft::PossibleCollections::HOUSES; | ||
| for item in collections.iter() { | ||
| let value: T::NftCollectionId = item.value().into(); | ||
| if value == collection_id { | ||
| possible_collection = *item; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
can we get rid of this for loop?
https://enodev.fr/posts/rusticity-convert-an-integer-to-an-enum.html
cuteolaf
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process_onboarded_assests(), the successfully processed houses have the FINALISING status