156 share distributor tokens #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g-shares-that-get-minted' into 156-share_distributor-tokens
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 70.58% 70.45% -0.14%
==========================================
Files 49 49
Lines 3424 3503 +79
==========================================
+ Hits 2417 2468 +51
- Misses 1007 1035 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
letodunc
requested changes
Sep 22, 2022
| pub fn owner_and_shares(collection_id: T::NftCollectionId, item_id: T::NftItemId) -> Vec<(T::AccountId, Percent)>{ | ||
|
|
||
| //Get owners and their reserved contribution to the bid | ||
| let infos = HousingFund::Reservations::<T>::get((collection_id,item_id)).unwrap(); |
There was a problem hiding this comment.
add a test to ensure that the (collection_id, item_id) is present in the storage before the unwrap
There was a problem hiding this comment.
collection_id and item_id are parameters passed by the bidding pallet to the share_distributor pallet.
|
|
||
| //Get owners and their reserved contribution to the bid | ||
| let infos = HousingFund::Reservations::<T>::get((collection_id,item_id)).unwrap(); | ||
| let vec0 = infos.contributions; |
There was a problem hiding this comment.
give name more meaningful names
letodunc
approved these changes
Sep 22, 2022
cuteolaf
pushed a commit
to cuteolaf/fair-squares
that referenced
this pull request
Oct 7, 2022
…ibutor-tokens 156 share distributor tokens
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Two helpers functions were added to:
housing_fundSuggested Solution
TokenIdstoringu32, and initialised at 0. it is tracking the Assets class IDshare_distributor, 'type AssetId = u32` was added in order to apply the advice received on stackexchange ==> https://substrate.stackexchange.com/questions/2857/how-do-i-hardcode-asset-idstype.rsthe token_id field was added tostruct Ownershipwith the type<T as pallet::Config>::AssetIdfn owner_and_shares(collection_id,item_id) -> owner_and_shares(collection_id: T::NftCollectionId, item_id: T::NftItemId) -> Vec<(T::AccountId, f64)>fn create_tokens(origin: OriginFor<T>, account: T::AccountId)In the next step tokens distribution to the owners by the virtual account will be implemented.