-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add utility pallet #131
feat: add utility pallet #131
Conversation
17a660b
to
6daa8a9
Compare
@@ -141,4 +147,4 @@ try-runtime = [ | |||
"pallet-onboarding/try-runtime", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for not adding "pallet-utility/try-runtime"
here?
and there is also the missing "pallet-utility/runtime-benchmarks"
in the runtime-benchmark
section.
Usually I refer to the following Files/folder to add pallets:
https://github.com/paritytech/substrate/blob/polkadot-v0.9.26/bin/node/runtime/Cargo.toml
I also realise that this rule (adding the pallet in try-runtime and runtime-benchmark) was not always respected in implementation of previous pallets. Let's learn & improve together!!
@@ -595,6 +602,7 @@ construct_runtime!( | |||
Preimage: pallet_preimage, | |||
Council: pallet_collective::<Instance1>, | |||
Democracy: pallet_democracy, | |||
Utility: pallet_utility, | |||
// flag add pallet runtime | |||
} | |||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here also, missing [pallet_utility, Utility]
in the define_benchmark
section.
To prevent missing things when adding a new pallet, there is a script that automatize it for you. It's add_new_pallet.sh in the scripts folder. You execute it from the root folder of the project. In your case, a use could be scripts/add_new_pallet.sh utility Utility. Everything will be correctly configured for the basic add in the project. Then you can customize it with what you need. |
No sure why the coverage tests are failing, might have to do with the that it's an external PR |
Codecov Report
@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 73.13% 73.13%
=======================================
Files 40 40
Lines 2922 2922
=======================================
Hits 2137 2137
Misses 785 785
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@cuteolaf can you please check the logs for the benchmarking and provide a fix. |
A few things I do before sending a commit:
In my experience, If all the checks above pass on your local node, your commit will checkout without ANY problem. |
* feat: add utility pallet * add: benchmark, try-runtime * fix: error in macro
No description provided.