-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization support #37
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we should localise error messages like this
It makes it harder to search for solutions, harder for people trying to provide support, and doesn't really benefit users. We dont localise error messages in other projects, especially none user facing ones like this.
01c0576
to
7386425
Compare
We could maybe introduce error codes that make it accessible for replacement on the embedding application side? |
That's the goal, having a central But as mentioned above, that's going to be a separate PR (probably after #94 is merged) |
Inspired by Enigma's and JADX's equivalents, but heavily stripped down. Only supports mapping format names for now, exception messages are going to be tackled in a separate PR.