Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace setup.py with newer package definition standard #89

Closed
julian-belina opened this issue Sep 18, 2024 · 2 comments
Closed

Replace setup.py with newer package definition standard #89

julian-belina opened this issue Sep 18, 2024 · 2 comments

Comments

@julian-belina
Copy link
Collaborator

When installing tsam I get the warning

" DEPRECATION: Legacy editable install of tsam==2.3.4 from file:///C:/Programming/tsam (setup.py develop) is deprecated. pip 25.0 will enforce this behaviour change. A possible replacement is to add a pyproject.toml or enable --use-pep517, and use setuptools >= 64. If the resulting installation is not behaving as expected, try using --config-settings editable_mode=compat. Please consult the setuptools documentation for more information. Discussion can be found at pypa/pip#11457"

Although a setupy.py file is not deprecated, the use of a pyproject.toml is strongly recommended.

https://packaging.python.org/en/latest/guides/modernize-setup-py-project/

@l-kotzur
Copy link
Collaborator

@julian-belina Thanks for pointing out. Do you have setup something similar for FINE? Is it easy for you to reproduce here?

@julian-belina
Copy link
Collaborator Author

@l-kotzur Yes, I did that for FINE and will do it for TSAM at the next hackathon in about two weeks.

julian-belina added a commit that referenced this issue Oct 15, 2024
- I have transitioned from setup.py to pyproject.toml . #89
- Changed the layout from flat to source. [See here for advantages](https://packaging.python.org/en/latest/discussions/src-layout-vs-flat-layout/)
- Updated the installation description in the README.md
- Fixed a couple of deprecation and future warnings, reported in #91
---------

Co-authored-by: Julian Belina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants