Make Clones share the same UndoManager #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place` instead of `StyledTextAreaModel#replace` to avoid a NullPointerException if the initial StyledTextAreaModel is disposed while clones still exist.
…edTextAreaModel has been disposed or not.
|
With this approach, do these lines that update the caret and selection post-replacement still need to be there? Edit: Just tested this out myself using CloneDemo. Without those lines, whenever I input text into the area, the caret doesn't move one letter to the write. So, they do need to be there. However, I don't think my test tests if a model's caret position & selection are where they should be. |
Conflicts: richtextfx/src/main/java/org/fxmisc/richtext/AreaFactory.java richtextfx/src/main/java/org/fxmisc/richtext/StyledTextArea.java richtextfx/src/main/java/org/fxmisc/richtext/StyledTextAreaModel.java
…revious merge commit.
…were missed in previous commit.
|
I'm closing this because I think #251 makes more sense in the long-term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comments in #233.