Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the final commit (4d86628) could be done better. However, I'm not sure how to get around a plumbing issue.
If a new
EmptyParagraph
is created anywhere outside ofEditableStyledDocument
, it doesn't have the correct style object for itsemptyTextStyle
(e.g. StyledDocumentBase, NormalParagraph, ReadOnlyStyledDocument). Additionally, itsparagraphStyle
isn't always correct either when it is created in some method in StyledDocument and ReadOnlyStyledDocument.I think the only good solution is to remove
EmptyParagraph
'semptyTextStyle
field and use the StyledDocument classes to check the Paragraph type before returning a style object, such as:Doing the above would require another change.
ClipboardActions
has a default method that creates aReadOnlyStyledDocument
, but it doesn't have any reference within itself for getting the two styles for its new constructor. So, it'd also need to have two getters for the styles. Since it's name is ClipboardActions, I wasn't sure if something should further extend that. Possibly an interface calledStyledClipboardActions
?