-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 6.0 Shift #470
Laravel 6.0 Shift #470
Conversation
The Laravel framework adopts the PSR-2 coding style with some additions. Laravel apps *should* adopt this coding style as well. However, Shift allows you to customize the adopted coding style through by using your [PHP CS Fixer][1] config within your project. You may use [Shift's .php_cs][2] file as a base. [1]: https://github.com/FriendsOfPHP/PHP-CS-Fixer [2]: https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200
Laravel recommends using the `Str` and `Arr` class methods directly instead of the respective helper functions. These helper functions are [deprecated in Laravel 5.8][1] and will be removed in a future version. [1]: laravel/framework#26898
In an effort to make upgrading the constantly changing config files easier, Shift defaulted them so you can review the commit diff for changes. Moving forward, you should use ENV variables or create a separate config file to allow the core config files to remain automatically upgradeable.
From the [PHPUnit 8 release notes][1], the `TestCase` methods below now declare a `void` return type: - `setUpBeforeClass()` - `setUp()` - `assertPreConditions()` - `assertPostConditions()` - `tearDown()` - `tearDownAfterClass()` - `onNotSuccessfulTest()` [1]: https://phpunit.de/announcements/phpunit-8.html
❌ Shift could not upgrade your HTTP Kernel because it differed from the default version. You will need to compare this file against the default Laravel 6.0 version and merge any changes. |
|
ℹ️ Laravel 6.0 changed the default Redis client from However, if possible, consider switching to phpredis to gain the performance of its PHP extension and avoid using the deprecated |
ℹ️ Shift makes an effort to update your dependencies for Laravel 6.0. While many of the popular packages are reviewed, you may have to update additional packages or version constraints in order for your application to be compatible with Laravel 6.0. Watch dealing with dependencies for tips on handling package incompatibilities. |
// no mass assignment protection or events...
$post->user()->update(['foo' => 'bar']);
// mass assignment protection and events...
$post->user->update(['foo' => 'bar']); Shift found potential uses of the
|
ℹ️ The Eloquent model's |
Shift detected the following uses of the
|
ℹ️ Laravel 6.0 made performance optimizations for integer key types. If you are using a string as your model's primary key, you may set the /**
* The "type" of the primary key ID.
*
* @var string
*/
protected $keyType = 'string'; |
ℹ️ The |
ℹ️ Previous versions of Laravel would retry jobs indefinitely. Beginning with Laravel 6.0, the |
ℹ️ Shift detected you are using a Laravel package which has its own assets or views which may need to be regenerated after upgrading. Be sure to use |
🎉 Congratulations, you're now running the latest version of Laravel. The following Shifts can ensure your app is fully upgraded and following the practices recommended by Laravel and the community:
In addition, stay upgraded forever as well as run these Shifts by subscribing to one of the new Shifty Plans. |
Apply fixes from StyleCI
This pull request includes the changes for upgrading to Laravel 6.0. Feel free to commit any additional changes to the
shift-19113
branch.Before merging, you need to:
shift-19113
branchcomposer update
(if the scripts fail, add--no-scripts
)If you need help with your upgrade, check out the Human Shifts. You may also join the Shifty Coders Slack workspace to level-up your Laravel skills.