Fixing #11 #23
Merged
Fixing #11 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes #11, following the detective work done by @mtzguido.
When finding a non-informative witness for type t, we were creating the witness term e, and then calling the checker to get the derivation of (e : non_informative t). But we can construct this derivation by appealing to the typing of the non-informative combinators in Pulse.Lib.Core and asking the callers of get_non_informative_witness to provide us typing for t.
The PR follows this route for t being unit, prop, erased, or squash type. There are other cases there, e.g. ghost refs and pcm refs. Will add them soon.