[4.0] Cherry-pick two commits to fix crash with p2p interfaces on *BSD #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zebra did not have a handler for tunnels in v6 for some reason. Add code to handle the broadcast address for both addition and deletion. This appears to fix the crash. There might still need to be some work to make the code `work` properly for this type of tunnel. Fixes: FRRouting#2063 Signed-off-by: Donald Sharp <[email protected]>
When I implemented the same functionality in add_ipv6 that add_ipv4 has I just assumed that broad would not be NULL with the ZEBRA_IFA_PEER flag set. Modify the code to act similiar to the flow of control in add_ipv4. Signed-off-by: Donald Sharp <[email protected]>
The SIOCGIFMEDIA ioctl returns EINVAL when a virtual interface is given (e.g. tunnel interfaces). This was making zebra produce lots of irrelevant log messages during startup, which were a source of concern for many users. Silence these log messages since they can't be avoided and are harmless. Signed-off-by: Renato Westphal <[email protected]>
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4313/ This is a comment from an EXPERIMENTAL automated CI system. Warnings Generated during build:Ubuntu 18.04 amd64 build: Successful with additional warnings:Debian Package lintian failed for Ubuntu 18.04 amd64 build: CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base38 Static Analyzer issues remaining.See details at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2338.