pimd: eBGP integration for SA loop detection #17699
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzalamena
force-pushed
the
msdp-ebgp
branch
4 times, most recently
from
718e421 to
cacc6cf
Compare
Implement a new zebra API to request route lookup results. This is similar to what `ZEBRA_IPV4_NEXTHOP_LOOKUP_MRIB` does, but it gets route information and all next hop information (uses dynamically allocated memory instead of expecting static array). Signed-off-by: Rafael Zalamena <[email protected]>
Implement the 'RFC 4611 Section 2.1. Peering between PIM Border Routers' knob to configure the expected eBGP remote AS number for detecting loops. Signed-off-by: Rafael Zalamena <[email protected]>
Implement the 'RFC 4611 Section 2.1. Peering between PIM Border Routers' recommendation of using the peer AS number to check for loops in the topology when using direct inter-domains connections. Signed-off-by: Rafael Zalamena <[email protected]>
Let users know that they can utilize the BGP AS integration to detect loops in SAs using the network topology. Signed-off-by: Rafael Zalamena <[email protected]>
Allow MSDP peers to hold the following new information: - Amount of RPF look up failures - Amount of incoming SAs filtered - Amount of outgoing SAs filtered Signed-off-by: Rafael Zalamena <[email protected]>
Add new version of `show msdp peer` command with extra details and a new command to clear MSDP peer counters. Signed-off-by: Rafael Zalamena <[email protected]>
rzalamena
force-pushed
the
msdp-ebgp
branch
2 times, most recently
from
91049f6 to
2db17c5
Compare
The previous logic was backwards. Signed-off-by: David Lamparter <[email protected]>
Add topology for testing MSDP eBGP integration. Signed-off-by: Rafael Zalamena <[email protected]>
|
Is there any particular reason we've added a second slightly different address lookup for pim instead of just modifying the first one? |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the optional knob to enable eBGP integration to detect loops in SAs. The detection of MSDP SA loops works as follow:
2.a. If the RPF route AS Path number matches the neighbor AS then the SA is accepted
2.b. if the RPF route AS Path number doesn't match the neighbor (or doesn't exist) the SA is rejected (means that the SA is not coming from the shortest path)