Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert IPv4 mapped IPv6 stuff #16588

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Aug 14, 2024

Revert recent IPv4 mapped IPv6 stuff since it's a regression even with 10.1 release. Revert for 10.1 is here: #16587.

Reverting:
#16439
#15614
#15368

@donaldsharp
Copy link
Member

did you have to apply these patches by hand as that we are getting frrbot style warnings?

@ton31337
Copy link
Member Author

nope, no changes by hand.

@ne-vlezay80
Copy link
Contributor

ci:rerun

1 similar comment
@ne-vlezay80
Copy link
Contributor

ci:rerun

@ton31337
Copy link
Member Author

@ne-vlezay80 no need rerunning, it's in a good state to merge, verify source check can be ignored.

@Jafaral
Copy link
Member

Jafaral commented Aug 20, 2024

This revert looks a bit "off". If I recall, when you revert a PR, you just revert the PR and that should only add the the "revert" msg to the PR commit, not every s commit like I see here.

@Jafaral
Copy link
Member

Jafaral commented Aug 20, 2024

Which PR introduced "IPv4 mapped IPv6" ?

@ton31337
Copy link
Member Author

Updated PR's description.

@Jafaral
Copy link
Member

Jafaral commented Aug 22, 2024

closed by #16615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants