Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: fix colored nexthops resolution #16003

Merged
merged 1 commit into from
May 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bgpd/bgp_nht.c
Original file line number Diff line number Diff line change
Expand Up @@ -972,12 +972,12 @@ void bgp_nexthop_update(struct vrf *vrf, struct prefix *match,
* which should provide a better infrastructure to solve this issue in
* a more efficient and elegant way.
*/
if (nhr->srte_color == 0 && bnc_nhc) {
if (nhr->srte_color == 0) {
struct bgp_nexthop_cache *bnc_iter;

frr_each (bgp_nexthop_cache, &bgp->nexthop_cache_table[afi],
bnc_iter) {
if (!prefix_same(&bnc_nhc->prefix, &bnc_iter->prefix) ||
if (!prefix_same(match, &bnc_iter->prefix) ||
bnc_iter->srte_color == 0 ||
CHECK_FLAG(bnc_iter->flags, BGP_NEXTHOP_VALID))
continue;
Expand Down
Loading