debian: Don't install sample dplane plugin

[gromit1811]

Without this, the Debian package build fails because dplane_sample_plugin.so gets compiled but not installed.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13723/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13723/artifact/TOPO8U18AMD64/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 i386 part 9
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 0
• Addresssanitizer topotests part 8
• Static analyzer (clang)
• Topotests Ubuntu 18.04 amd64 part 9
• Ubuntu 18.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Addresssanitizer topotests part 6
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 arm8 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 6
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 6
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 4
• Debian 9 deb pkg check
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 arm8 part 7
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 i386 part 2
• Topotests debian 10 amd64 part 5
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 6
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 amd64 part 5
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 i386 part 1
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests Ubuntu 18.04 i386 part 8
• Topotests debian 10 amd64 part 8
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 i386 part 0
• Topotests Ubuntu 18.04 i386 part 5
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 arm8 part 4
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 arm8 part 9
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13723/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

[ton31337]

Can we see the build error message/log or so?

[gromit1811]

Sure, I wanted to include it right with the PR but it already scrolled out of my terminal history and I was too lazy to restart a build without the fix 😉 Did that now:

	rm -f debian/frr-doc.debhelper.log debian/frr-pythontools.debhelper.log debian/frr-rpki-rtrlib.debhelper.log debian/frr-snmp.debhelper.log debian/frr.debhelper.log
   debian/rules override_dh_missing
make[1]: Entering directory '/b/frr'
dh_missing --fail-missing
dh_missing: warning: usr/lib/x86_64-linux-gnu/frr/modules/dplane_sample_plugin.so exists in debian/tmp but is not installed to anywhere 
	The following debhelper tools have reported what they installed (with files per package)
	 * dh_install: frr (48), frr-doc (26), frr-pythontools (4), frr-rpki-rtrlib (1), frr-snmp (9)
	 * dh_installdocs: frr (2), frr-doc (0), frr-pythontools (0), frr-rpki-rtrlib (0), frr-snmp (0)
	 * dh_installexamples: frr (0), frr-doc (0), frr-pythontools (0), frr-rpki-rtrlib (0), frr-snmp (0)
	 * dh_installinfo: frr (0), frr-doc (1), frr-pythontools (0), frr-rpki-rtrlib (0), frr-snmp (0)
	 * dh_installman: frr (16), frr-doc (0), frr-pythontools (0), frr-rpki-rtrlib (0), frr-snmp (0)
	If the missing files are installed by another tool, please file a bug against it.
	When filing the report, if the tool is not part of debhelper itself, please reference the
	"Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+).
	  (in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz)
	Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built
	If the omission is intentional or no other helper can take care of this consider adding the
	paths to debian/not-installed.

	Remember to be careful with paths containing "x86_64-linux-gnu", where you might need to
	use a wildcard or (assuming compat 13+) e.g. ${DEB_HOST_MULTIARCH} in debian/not-installed
	to ensure it works on all architectures (see #961104).
dh_missing: error: missing files, aborting
make[1]: *** [debian/rules:111: override_dh_missing] Error 255
make[1]: Leaving directory '/b/frr'
make: *** [debian/rules:39: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
gbp:error: 'dpkg-buildpackage -uc -us -b' failed: it exited with 2

[gromit1811]

I don't know whether dplane_sample_plugin.so is actually supposed to be installed, but it looks like a source code example you can use as the basis for your own plugins and installing the binary version of an empty plugin didn't sound very useful to me.

[ton31337]

Thanks.