Add td sync wf #146
Add td sync wf #146
Conversation
| sync_all_installed_devices = int(task["inputData"]["sync_all_installed_devices"]) | ||
| data = {} | ||
| # If there is MOCK_UNICONFIG_URL_BASE in composefile use mock uniconfig to get installed devices | ||
| if MOCK_UNICONFIG_URL_BASE != "none": |
There was a problem hiding this comment.
I would make this more robust i.e.
if MOCK_UNICONFIG_URL_BASE and MOCK_UNICONFIG_URL_BASE != "none"
also, is the "none" magic keyword needed ? wouldn't empty / undefined parameter be a more generic solution ?
There was a problem hiding this comment.
... considering all the input params are essentially optional
There was a problem hiding this comment.
after discussion with Jozef i set here default value
- MOCK_UNICONFIG_URL_BASE=http://uniconfig_mock:1080
and commented it
it looks fine to me that if someone want use it he will just uncomment this line
| import requests | ||
| import util | ||
| from frinx_conductor_workers.frinx_rest import ( | ||
| additional_uniconfig_request_params, uniconfig_url_base) | ||
|
|
||
| TOPOLOGY_DISCOVERY_BASE_URL = "http://topology-discovery:5000/api" |
There was a problem hiding this comment.
This should come from env vars, just like the UC URL BASE
There was a problem hiding this comment.
correct, changed. 👍
| "Content-Type": "application/json", | ||
| "X-Auth-User-Roles": "admin-1", | ||
| } | ||
| MOCK_UNICONFIG_URL_BASE = os.getenv("MOCK_UNICONFIG_URL_BASE") |
There was a problem hiding this comment.
This one is just for demo right ? and should go away eventually
I would add a comment here: // TODO deleteme after demo
There was a problem hiding this comment.
i think it can be useful for local development and also for some demo for future that we can show these WF on mock UC server and we dont need necessary some simulated/real devices
| To use mock uniconfig change in fm-workflow composefile env to MOCK_UNICONFIG_URL_BASE=http://uniconfig_mock:1080 | ||
| """ | ||
| devices = task["inputData"]["devices"] | ||
| labels = task["inputData"]["labels"] |
There was a problem hiding this comment.
not sure if this is safe in case labels are not in the input
should be something like task["inputData"].get("labels", "") ... with default empty value
this applies to all input params
There was a problem hiding this comment.
I was worried about this one also during development,
But labels are here always if input in WF is empty it will be just empty string labels="" so it is safe if user using workflow
add TD sync function as a WF