Add proxy #1
Merged
Add proxy #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfrister
commented
Jul 17, 2018
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
So, reading the paragraph above, these are only instructions on how to apply the license to source code, so these fields are rightly not filled in.
main.go
Outdated
| authCookieCh <- c | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
Return error message if cookie not found
main.go
Outdated
| ) | ||
|
|
||
| func main() { | ||
| proxyAddr := "127.0.0.1:8124" |
Better to tell users about the problem than just doing nothing.
The auth callback address must be fixed, so we can allow the redirect_uri at the identity provider.
sbrandtb
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See README on how this works.