Fix compilation error on newer ubuntu releases #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since glibc >= 2.34, MINSIGSTKSZ and SIGSTKSZ are no longer constant on Linux. As a result, the definition "fatalSigStack[2*SIGSTKSZ]" fails to be compiled. Thus, we need to dynamically allocate it. Change-Id: Ibccc367818483b9c94beda871d1d95367d1e8b04 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/53183 Reviewed-by: Gabe Black <[email protected]> Maintainer: Gabe Black <[email protected]> Tested-by: kokoro <[email protected]> (cherry picked from commit 39d4cdcd6bf1966b21c0d598e529c011f551b6bb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo can not be compiled on Ubuntu 22.04 because in glibc >= 2.34, SIGSTKSZ is changed to a system call instead of a constant value. I cherry picked the commit from gem5 upstream to fix the issue. It now compiles on Ubuntu 20.04/22.04.
Not sure there is any other issue causing "Unfortunately the repo doesn't appear to run correctly when tested on Ubuntu 20.04", seems working fine now :)
Upstream commit messeage:
Since glibc >= 2.34, MINSIGSTKSZ and SIGSTKSZ are no longer constant on Linux. As a result, the definition
"fatalSigStack[2*SIGSTKSZ]" fails to be compiled.
Thus, we need to dynamically allocate it.
Change-Id: Ibccc367818483b9c94beda871d1d95367d1e8b04 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/53183
Reviewed-by: Gabe Black [email protected]
Maintainer: Gabe Black [email protected]
Tested-by: kokoro [email protected]
(cherry picked from commit 39d4cdcd6bf1966b21c0d598e529c011f551b6bb)