Skip to content

Commit

Permalink
[CELEBORN-1478] Fix wrong use partitionId as shuffleId when readParti…
Browse files Browse the repository at this point in the history
…tion

### What changes were proposed in this pull request?
Change partitionId to shuffleId

### Why are the changes needed?
As title, Although the partitionId is used as the shuffleId when reading a partition, it has no effect on the final result

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
PASS GA

Closes apache#2589 from RexXiong/CELEBORN-1478.

Authored-by: Shuang <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
  • Loading branch information
RexXiong authored and SteNicholas committed Jun 24, 2024
1 parent 02efb0b commit d0563ea
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,7 @@ public CelebornInputStream readPartition(
int[] mapAttempts,
MetricsCallback metricsCallback)
throws IOException {
if (partitionId == Utils$.MODULE$.UNKNOWN_APP_SHUFFLE_ID()) {
if (shuffleId == Utils$.MODULE$.UNKNOWN_APP_SHUFFLE_ID()) {
logger.warn("Shuffle data is empty for shuffle {}: UNKNOWN_APP_SHUFFLE_ID.", shuffleId);
return CelebornInputStream.empty();
}
Expand Down

0 comments on commit d0563ea

Please sign in to comment.