Setting Initial super user #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to add initial super users which are set at api-umbrella.yml
Documentation for setting initial super users
|
Please apply one of the following labels to the PR: 'patch', 'minor', 'major'. |
wistefan
reviewed
Aug 30, 2021
| @@ -150,6 +156,15 @@ local function seed_initial_superusers() | |||
| admin["authentication_token"] = random_token(40) | |||
| end | |||
| admin["updated_at"] = nowMongoDate | |||
|
|
|||
There was a problem hiding this comment.
The log is mis-leading and should either be removed or made more concrete. The comment in l160 is also superfluous in my opinion, since thats information present in the git-log
wistefan
reviewed
Aug 30, 2021
|
|
||
| -- Changes added by FIWARE Foundation (Chandra) for setting initial super users - Start | ||
| ngx.log(ngx.INFO, "Chandra user name is email -- Printing the value in if->notAdmin loop : ", emailUserName) | ||
| if emailUserName then |
There was a problem hiding this comment.
In case username and email are configured differently, wouldn't it be better to throw an error instead of a silent replace?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.