Prepare for release of numpy 2.0 by using ruff ruleset #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
commented
Jun 7, 2024
garth-wells
reviewed
Jun 7, 2024
| @@ -34,7 +34,7 @@ dependencies = [ | |||
|
|
|||
| [project.optional-dependencies] | |||
| docs = ["markdown", "pyyaml", "sphinx", "sphinx_rtd_theme"] | |||
| lint = ["ruff"] | |||
| lint = ["ruff>=0.2.0"] | |||
There was a problem hiding this comment.
Is this pin required for ruff to run?
There was a problem hiding this comment.
According to the release notes I've linked above, yes:
Ruff plugin
Many of the changes covered in the 2.0 release notes and in this migration guide can be automatically adapted > in downstream code with a dedicated Ruff rule, namely rule NPY201.
You should install ruff>=0.2.0 and add the NPY201 rule to your pyproject.toml:
garth-wells
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://numpy.org/devdocs/numpy_2_0_migration_guide.html#ruff-plugin