Constrain scalar types with concept #2690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the diff I've used dolfinx::scalar in some places where instead I should have used std::floating_point so I will make these changes. This would support changing all mesh related T to U throughout. |
jhale
commented
Jun 28, 2023
cpp/dolfinx/fem/discreteoperators.h
Outdated
| @@ -47,7 +47,7 @@ namespace dolfinx::fem | |||
| /// @param[in] V1 Nédélec (first kind) element and and dofmap for | |||
| /// corresponding space to interpolate into | |||
| /// @param[in] mat_set A functor that sets values in a matrix | |||
| template <typename T, std::floating_point U = dolfinx::scalar_value_type_t<T>> | |||
| template <dolfinx::scalar T, std::floating_point U = dolfinx::scalar_value_type_t<T>> | |||
There was a problem hiding this comment.
Does this constraint U to be the same scalar type as T? Is this necessary?
garth-wells
reviewed
Jun 28, 2023
garth-wells
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR constrains T (which is usually used to denote a scalar related to the finite element coefficients) to be a real or complex floating point type. Let me know if this needs to be widened re: multi-precision support.
In terms of naming 'field' might be more mathematically correct than 'scalar'.
I wonder also if we should change all of the Mesh related Ts to Us throughout?