Profiler: Setup for usage on Windows #4260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
approved these changes
Jan 9, 2025
bylaws
approved these changes
Jan 9, 2025
Sonicadvance1
force-pushed
the
profile_win32
branch
from
9585936 to
4e5916f
Compare
|
Had to do some changes to this to get it fully working. Had to fix a issue in CRT/IO that files opened for writing should be shared with other writers, otherwise the trace file would get ENOENT. Also had to actually initialize the profiler interface. |
This will get gpuviz working under Wine.
Fixes trace file opening since it needs to share with other users opening the file for writing.
Sonicadvance1
force-pushed
the
profile_win32
branch
from
4e5916f to
4c9f1b1
Compare
lioncash
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will get gpuviz working under Wine.